Make sure xodr and xosc crash when exception occurs#13
Open
victorjarlow wants to merge 2 commits intojavedulu:masterfrom
Open
Make sure xodr and xosc crash when exception occurs#13victorjarlow wants to merge 2 commits intojavedulu:masterfrom
victorjarlow wants to merge 2 commits intojavedulu:masterfrom
Conversation
Owner
|
Guide-Post doesnt seem to be a valid enum from the xsd of opendrive ? The code is autogenerated and any further regeneration will override the changes. Could you please submit a merge request without the guide-post change will go ahead and merge it.,. |
Contributor
Author
|
I've removed the guide-post commit now. Just out of curiosity, what method do you use to autogenerate the code? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xodr::parse() and xosc::parse() should crash when an exception occurs. If exceptions are caught, then software that uses ad-xolib as a library will have no way of knowing what went wrong in the call stack.
Therefore I moved the try/catch statement to the appln/main_xxx files instead.